Add RFC 91 text: GDALDataset::Close() method #7108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2023
|
Thanks @rouault . I was one of those that used the ugly hacky error detection. |
schwehr
reviewed
Jan 20, 2023
| ------------- | ||
|
|
||
| The destructor of gdal.Dataset is modified to test the return value of GDALClose() | ||
| and emits a CPLError(CE_Failure, ...) if the error state is clean (normally |
There was a problem hiding this comment.
no, the current formulation is intended. See commit rouault@c3c37ea
This is to make sure that the gdal.UseExceptions() mode throws an exception. It needs CPLGetLastErrorType() == CE_Failure, so if GDALClose() != CE_None and CPLGetLastErrorType() == CE_None, we issue a CPLError(CE_Failure, ...)
|
It looks good to me. A minor addition to the example to push it to safer side MyDataset::~MyDataset()
{
try {
MyDataset::Close();
} catch (...) {
// swallow error, optionally log it but ensure the action never throws
}
} |
mloskot
approved these changes
Jan 21, 2023
added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered view in https://github.com/rouault/gdal/blob/rfc91_text/doc/source/development/rfc/rfc91_dataset_close.rst